Skip to content

8373120: Virtual thread stuck in BLOCKED state#379

Open
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8373120-virtual-thread-stuck-blocked
Open

8373120: Virtual thread stuck in BLOCKED state#379
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8373120-virtual-thread-stuck-blocked

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Mar 12, 2026 •
edited by openjdk bot
Loading

Fixes another Virtual Thread issue that manifests in JDK 25.

Unfortunately, JDK-8369238 adjusted the same block (added interruptible flag). That issue is too large to backport at this time. We might backport it later. But we can fix this particular issue by carefully dealing with interruptible conflict. The code shape looks to be the same and fixes the reproducer.

Additional testing:

  • New regression test fails without the fix, passes with it; 1000x iterations
  • Linux x86_64 server fastdebug, jdk_loom hotspot_loom, 100x
  • Linux x86_64 server fastdebug, java/lang/Thread/virtual/stress/, 500x
  • Linux AArch64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8373120 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8373120: Virtual thread stuck in BLOCKED state (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/379/head:pull/379
$ git checkout pull/379

Update a local copy of the PR:
$ git checkout pull/379
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/379/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 379

View PR using the GUI difftool:
$ git pr show -t 379

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/379.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2026

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@shipilev
Copy link
Member Author

shipilev commented Mar 12, 2026

@pchilano, would be happy to hear what you think here :)

@openjdk
Copy link

openjdk bot commented Mar 12, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 26aab3cccdbcf98c329c8d67093eb2dbf4b164e5 8373120: Virtual thread stuck in BLOCKED state Mar 12, 2026
@openjdk
Copy link

openjdk bot commented Mar 12, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 12, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2026

Webrevs

pchilano
pchilano approved these changes Mar 12, 2026
View reviewed changes
Copy link

@pchilano pchilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for backporting!

@shipilev
Copy link
Member Author

shipilev commented Mar 12, 2026

Thank you for looking! I'll stress test it a bit more and then request approval for 25u.

@shipilev
Copy link
Member Author

shipilev commented Mar 13, 2026

Stress tests pass, see PR body. Oh, but we should do JDK 26 first: openjdk/jdk26u#111

@shipilev
Copy link
Member Author

shipilev commented Mar 17, 2026

/approval request Fixes another Virtual Threads issue. The issue reproduces in 25u, a regression since JDK 24. The patch does not apply cleanly due to minor conflicts, easy to resolve. Reproducer fails without the fix, passes with it. Stress tests pass. Was in mainline for 1.5 months without bugtail. We expect that users would see this issue in real deployments, if not fixed. Risk is medium: touches VT paths, but it fairly mild manner and fixes the VT corner case.

@openjdk
Copy link

openjdk bot commented Mar 17, 2026

@shipilev
8373120: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pchilano pchilano pchilano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shipilev @pchilano